-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
9017cb3
to
defbab1
Compare
@gwendalF have you implemented this, too?
|
Adding a Clippy CI check is good, but I'm getting 1 error here: Line 78 in 4dc4709
It wants the borrow removed |
We can remove the borrow since it does not appears to be used somewhere else so we can move the path on the open function |
I've updated the case to not override properties. May need check because there is a bunch of clone and staff, so we can surely do it better. May need a visitor pattern to merge two serde_json::Value |
1e97a42
to
efe312f
Compare
@kirillt I've updated the Link to use your solution of tempfile and moving to destination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Use atomic files whenever we want to use files. It ensure there are written atomicaly. Also we have the possibility to manage the case when the file is already present and do something with the data. Currently it's just overwritten but something better can be done
Fix #48