Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Folder creation capability #41

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Jan 16, 2024

@tuancoltech tuancoltech self-assigned this Jan 16, 2024
@kirillt
Copy link
Member

kirillt commented Jan 25, 2024

Looks good. Let's also enhance this feature in ARK mode ("Roots" tab):

  • when a folder is added, it should be immediately displayed in "Roots" tab
  • same button is enough: new folder is always either a root, or a favorite

We could also implement this feature in this PR:

@kirillt
Copy link
Member

kirillt commented Jan 25, 2024

And let's also take #51 in the scope, copying the checklist from there.

General points:

  • Switch-off ARK view when there is no .ark-roots file
  • Remember the active tab, start with the tab which was active last time

File-picking mode:

  • Enable ARK view in file-picking mode
    For this we need to implement one of these:
    • Embed Resource Grid from Navigator
    • Allow selecting a folder and switch back to classical view.

* [feature] Automatically pin folders (Make Root/Favorite) when creating new folder in ARK mode: #41 (comment)
@tuancoltech
Copy link
Collaborator Author

Looks good. Let's also enhance this feature in ARK mode ("Roots" tab):

  • when a folder is added, it should be immediately displayed in "Roots" tab
  • same button is enough: new folder is always either a root, or a favorite

We could also implement this feature in this PR:

@kirillt Both enhancement in ARK mode and folder pinning from classical view have been implemented. Please check out the demo video in the PR's description.

@tuancoltech
Copy link
Collaborator Author

tuancoltech commented Jan 30, 2024

And let's also take #51 in the scope, copying the checklist from there.

General points:

  • Switch-off ARK view when there is no .ark-roots file
  • Remember the active tab, start with the tab which was active last time

File-picking mode:

  • Enable ARK view in file-picking mode
    For this we need to implement one of these:

    • Embed Resource Grid from Navigator
    • Allow selecting a folder and switch back to classical view.

@kirillt Since the changes in this PR are already large, and the scope of the changes is growing bigger and bigger, I suggest making this enhancement in a separate PR :). I can take care of it.
Thanks.

Comment on lines +44 to +50

findViewById<MaterialButton>(R.id.btn_open_file_mode).setOnClickListener {
resolvePermissions()
ArkFilePickerFragment
.newInstance(getFilePickerConfig(mode = ArkFilePickerMode.FILE))
.show(supportFragmentManager, null)
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a sample of how to open the picker in FILE mode.

@kirillt
Copy link
Member

kirillt commented Jan 31, 2024

Great job, thank you

@kirillt kirillt merged commit 270acc4 into main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants