Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI by reduce dependency between steps #437

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

hieuwu
Copy link
Collaborator

@hieuwu hieuwu commented Feb 12, 2024

🚀 Summary

Currently, total time taken to complete the whole build for each commit is ~10mins.
Build - 5 mins
Test - 2 mins (depends on build)
Lint and Klint - 2 mins (depends on test)
It takes about 7 mins before linting to be run while it is unnecessary making linting depends on test and build.
Other than that, linting can be requested to be fixed by reviewer before they approve the PR, hence it is fine to keep linting out of build or test steps

✅ Solution

By removing the dependency on test, linting could be run separately, it would reduce total time it takes to complete the build from 10mins to 8mins or faster
Result
Screenshot 2024-02-12 at 15 22 37

@hieuwu hieuwu added the enhancement New feature or request label Feb 12, 2024
@hieuwu hieuwu requested a review from kirillt February 12, 2024 07:51
@hieuwu hieuwu self-assigned this Feb 12, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kirillt
Copy link
Member

kirillt commented Feb 12, 2024

@hieuwu does this PR affect time to generate artifacts? If yes, then maybe we should depend on build step.

@kirillt kirillt merged commit 795f5ea into main Feb 12, 2024
7 checks passed
@hieuwu
Copy link
Collaborator Author

hieuwu commented Feb 12, 2024

@hieuwu does this PR affect time to generate artifacts? If yes, then maybe we should depend on build step.

It does not affect to any artifact uploading but all the artifacts are only available when all job are completed.

@hieuwu hieuwu deleted the feature/improve-ci-for-non-main-branch branch February 14, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants