-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI by reduce dependency between steps #437
Conversation
Quality Gate passedIssues Measures |
@hieuwu does this PR affect time to generate artifacts? If yes, then maybe we should depend on |
It does not affect to any artifact uploading but all the artifacts are only available when all job are completed. |
🚀 Summary
Currently, total time taken to complete the whole build for each commit is ~10mins.
Build - 5 mins
Test - 2 mins (depends on build)
Lint and Klint - 2 mins (depends on test)
It takes about 7 mins before linting to be run while it is unnecessary making linting depends on test and build.
Other than that, linting can be requested to be fixed by reviewer before they approve the PR, hence it is fine to keep linting out of build or test steps
✅ Solution
By removing the dependency on test, linting could be run separately, it would reduce total time it takes to complete the build from 10mins to 8mins or faster
Result