Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PoC) Feature-based analytics tracking #427

Merged
merged 16 commits into from
Mar 14, 2024
Merged

(PoC) Feature-based analytics tracking #427

merged 16 commits into from
Mar 14, 2024

Conversation

hieuwu
Copy link
Collaborator

@hieuwu hieuwu commented Dec 21, 2023 •
edited
Loading

🚀 Summary

Overview

This PR contains solution for feature-based analytics across screens with state and events tracking.

Practices

  • Analytics tracking must be put outside of the view layer (Fragments/Activities). Doing this helps us write unit test and
  • Analytics string tag must start with feature.

How to add new analytics for new feature

  • In analytics.xml file, add strings for screens and events want to track
  • Create analytics for feature, for example (FolderAnalytics/FolderAnalyticsImpl)
  • Provide the new analytics in AnalyticsModule
  • Inject analytics in ViewModel
  • Only track things via methods from ViewModel. Never inject analytics in Fragment/Activity

Issue: #397

🖼️ Screenshots:

N/A

@hieuwu hieuwu added the enhancement New feature or request label Dec 21, 2023
@hieuwu hieuwu requested a review from kirillt December 21, 2023 15:09
@hieuwu hieuwu self-assigned this Dec 21, 2023
@kirillt kirillt changed the title Replace Log usage with Timber Introduce Timber and Matomo Jan 2, 2024
@kirillt kirillt requested a review from mdrlzy January 2, 2024 11:54
@hieuwu hieuwu marked this pull request as draft January 13, 2024 12:07
@hieuwu hieuwu changed the title Introduce Timber and Matomo (PoC) Feature-based analytics tracking Jan 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hieuwu hieuwu marked this pull request as ready for review March 6, 2024 08:57
@mdrlzy mdrlzy merged commit f260b31 into main Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrlzy mdrlzy mdrlzy approved these changes

@kirillt kirillt Awaiting requested review from kirillt

Assignees

@hieuwu hieuwu

Labels
enhancement New feature or request
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieuwu @mdrlzy