Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Improve the UX of Manage folders screen #401

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[enhancement] Improve the UX of Manage folders screen #401

merged 1 commit into from
Oct 20, 2023

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Oct 17, 2023 •
edited
Loading

Improve the UX of Manage folders screen by:

  • Show the Add button when scrolling up.
  • Hide the Add button when scrolling down.
  • Keep the Add button shown when being at the top of the list.

#400

Result:

https://recordit.co/LtrZAge39x

@tuancoltech tuancoltech temporarily deployed to Development October 17, 2023 15:46 — with GitHub Actions Inactive
@tuancoltech tuancoltech self-assigned this Oct 17, 2023
@tuancoltech tuancoltech added enhancement New feature or request UX labels Oct 17, 2023
@tuancoltech tuancoltech temporarily deployed to Development October 17, 2023 15:55 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 17, 2023 15:58 — with GitHub Actions Inactive
@tuancoltech tuancoltech changed the title [enhancement] Improve the UX of Manage folders screen: Hide Add Folde… WIP: [enhancement] Improve the UX of Manage folders screen: Hide Add Folde… Oct 17, 2023
mdrlzy
mdrlzy requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@mdrlzy mdrlzy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If list is not full screen, scroll hides fab forever

Screenshot

image

@tuancoltech tuancoltech force-pushed the enhancement/improve_manage_folders_fab_ux branch from 3c593e1 to 93dce59 Compare October 18, 2023 15:05
@tuancoltech tuancoltech temporarily deployed to Development October 18, 2023 15:05 — with GitHub Actions Inactive
@tuancoltech tuancoltech changed the title WIP: [enhancement] Improve the UX of Manage folders screen: Hide Add Folde… WIP: [enhancement] Improve the UX of Manage folders screen Oct 18, 2023
@tuancoltech tuancoltech changed the title WIP: [enhancement] Improve the UX of Manage folders screen [enhancement] Improve the UX of Manage folders screen Oct 18, 2023
@tuancoltech
Copy link
Collaborator Author

If list is not full screen, scroll hides fab forever

Screenshot
image

@mdrlzy Thanks, that's a good catch.
I just changed the solution to a simpler strategy: Increase the list bottom padding.
Please re-review.

@tuancoltech tuancoltech temporarily deployed to Development October 18, 2023 15:15 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 18, 2023 15:18 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 18, 2023 15:18 — with GitHub Actions Inactive
@hieuwu
Copy link
Collaborator

hieuwu commented Oct 19, 2023

So far so good. Could you please spend a bit more time on trying other solution for this improvement? Adding padding at the bottom might reduce our space and lead to a big empty space in our screen. Just found this article to handle fab effect. Please give it a try.

https://www.geeksforgeeks.org/auto-hide-or-auto-extend-floating-action-button-in-recyclerview-in-android/

@tuancoltech tuancoltech force-pushed the enhancement/improve_manage_folders_fab_ux branch from 93dce59 to b2382c0 Compare October 19, 2023 15:28
@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 15:28 — with GitHub Actions Inactive
@tuancoltech
Copy link
Collaborator Author

tuancoltech commented Oct 19, 2023 •
edited
Loading

So far so good. Could you please spend a bit more time on trying other solution for this improvement? Adding padding at the bottom might reduce our space and lead to a big empty space in our screen. Just found this article to handle fab effect. Please give it a try.

https://www.geeksforgeeks.org/auto-hide-or-auto-extend-floating-action-button-in-recyclerview-in-android/

@hieuwu That's a nice approach.
I've changed the code to make it work in such mentioned way.
Please review.

@tuancoltech tuancoltech force-pushed the enhancement/improve_manage_folders_fab_ux branch from b2382c0 to 2884205 Compare October 19, 2023 15:33
@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 15:33 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 15:41 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 15:44 — with GitHub Actions Inactive
@tuancoltech
[enhancement] Improve the UX of Manage folders screen: Show Add butto…
2a13756 
…n when scrolling up, hide it when scrolling down.
@tuancoltech tuancoltech force-pushed the enhancement/improve_manage_folders_fab_ux branch from 2884205 to 2a13756 Compare October 19, 2023 16:35
@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 16:35 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 16:45 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 16:48 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 19, 2023 16:48 — with GitHub Actions Inactive
@kirillt kirillt requested review from mdrlzy and hieuwu October 20, 2023 12:15
hieuwu
hieuwu approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@hieuwu hieuwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirillt kirillt merged commit daaca01 into main Oct 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrlzy mdrlzy mdrlzy approved these changes

@hieuwu hieuwu hieuwu approved these changes

Assignees

@tuancoltech tuancoltech

Labels
enhancement New feature or request UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuancoltech @hieuwu @mdrlzy @kirillt