Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package renaming #387

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Package renaming #387

merged 1 commit into from
Oct 18, 2023

Conversation

kirillt
Copy link
Member

@kirillt kirillt commented Oct 8, 2023

From space.taran to dev.arkbuilders. Pay attention that it's not dev.ark-builders because hyphens are forbidden in package names.

@hieuwu
Copy link
Collaborator

hieuwu commented Oct 16, 2023

Almost there. Please also check the test package

@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 15:19 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 15:28 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 15:32 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 15:32 — with GitHub Actions Inactive
@tuancoltech
Copy link
Collaborator

Almost there. Please also check the test package

@hieuwu Thanks for pointing out. All is done, please check it again.

@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 15:58 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 16:08 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 16:11 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 16, 2023 16:11 — with GitHub Actions Inactive
Copy link
Collaborator

@hieuwu hieuwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad LGTM

@kirillt kirillt merged commit 19d92c6 into main Oct 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants