Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error when the folder is removed externally #83

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Nov 16, 2024

Handle error when the folder is removed externally
https://app.asana.com/0/1207829522063916/1207809744096491

@tuancoltech tuancoltech added the bug Something isn't working label Nov 16, 2024
@tuancoltech tuancoltech self-assigned this Nov 16, 2024
@tuancoltech tuancoltech changed the title WIP: Handle error when the folder is removed externally Handle error when the folder is removed externally Nov 28, 2024
Copy link
Member

@shubertm shubertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in emulator(Android 15). On physical devices(Android 10) it is crashing on fresh start. Uninstall app, install it again, open, crash.

@tuancoltech
Copy link
Collaborator Author

Works fine in emulator(Android 15). On physical devices(Android 10) it is crashing on fresh start. Uninstall app, install it again, open, crash.

@shubertm Could you provide the stack trace of the crash please?
And can you also provide me the bug report by this command?

adb bugreport > ./bug.zip

Thanks.

@shubertm
Copy link
Member

shubertm commented Dec 5, 2024

Works fine in emulator(Android 15). On physical devices(Android 10) it is crashing on fresh start. Uninstall app, install it again, open, crash.

@shubertm Could you provide the stack trace of the crash please?
And can you also provide me the bug report by this command?

adb bugreport > ./bug.zip

Thanks.

Surprisingly, stacktrace is not printing any error
I will provide the report

@shubertm
Copy link
Member

shubertm commented Dec 5, 2024

SVID_20241204_134430_1.mp4
  • There is need to detect deleted folder while notes are loaded to avoid opening deleted notes
  • Should also apply where note is already opened

@tuancoltech
Copy link
Collaborator Author

Works fine in emulator(Android 15). On physical devices(Android 10) it is crashing on fresh start. Uninstall app, install it again, open, crash.

@shubertm Can you provide a video record providing the flow overview which leads to crash?

@tuancoltech
Copy link
Collaborator Author

tuancoltech commented Dec 6, 2024

  • There is need to detect deleted folder while notes are loaded to avoid opening deleted notes
  • Should also apply where note is already opened

@shubertm This will be covered by fs-index when Memo is fully integrated with new ark-core library.
For now, we'll not do background monitoring of files change in Memo.

@shubertm
Copy link
Member

shubertm commented Dec 7, 2024

Works fine in emulator(Android 15). On physical devices(Android 10) it is crashing on fresh start. Uninstall app, install it again, open, crash.

@shubertm Can you provide a video record providing the flow overview which leads to crash?

SVID_20241207_110056_1.mp4

@tuancoltech
Copy link
Collaborator Author

Works fine in emulator(Android 15). On physical devices(Android 10) it is crashing on fresh start. Uninstall app, install it again, open, crash.

@shubertm Can you provide a video record providing the flow overview which leads to crash?

SVID_20241207_110056_1.mp4

@shubertm This crash is happening in main branch as well, and only Android 10 (and probably 8, 9 too).
So, it’s not related to the changes made in in this PR.

Please continue testing & reviewing the PR.
For the crash, I’ve created a different ticket for it here: https://app.asana.com/0/1207819682524134/1208903376779601.

Will investigate and fix in another branch.

Copy link
Member

@shubertm shubertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@shubertm
Copy link
Member

  • There is need to detect deleted folder while notes are loaded to avoid opening deleted notes
  • Should also apply where note is already opened

@shubertm This will be covered by fs-index when Memo is fully integrated with new ark-core library. For now, we'll not do background monitoring of files change in Memo.

@tuancoltech do we a ticket for this already in Asana?

@tuancoltech
Copy link
Collaborator Author

  • There is need to detect deleted folder while notes are loaded to avoid opening deleted notes
  • Should also apply where note is already opened

@shubertm This will be covered by fs-index when Memo is fully integrated with new ark-core library. For now, we'll not do background monitoring of files change in Memo.

@tuancoltech do we a ticket for this already in Asana?

@shubertm Not really, we just discussed about it over Telegram.
However, just in case you need a related Asana ticket, I think you can take a look here: https://app.asana.com/0/1207829522063916/1208782130889593

@tuancoltech tuancoltech merged commit 5d292cc into main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA_passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants