Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Acra with Firebase Crashlytics #75

Merged

Conversation

tuancoltech
Copy link
Collaborator

Replace Acra with Firebase Crashlytics:
https://app.asana.com/0/1207819682524134/1208211226661157

@tuancoltech tuancoltech added enhancement New feature or request feature labels Sep 14, 2024
@tuancoltech tuancoltech self-assigned this Sep 14, 2024
@tuancoltech tuancoltech changed the base branch from main to feature/new_ui_design September 14, 2024 03:37
@@ -0,0 +1,48 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider having 2 version of this one, for debug and release variant to avoid noise of data from both debug and release

Copy link
Collaborator Author

@tuancoltech tuancoltech Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hieuwu That's a good suggestion, but then we need to answer a question first:
Do we really want to monitor debug crash?
If no -> We can simply disable crash collection for debug build.
If yes -> We can create a debug app, which corresponds to a separate debug version of the google-services.json file (and of course, a different package name, too) as per your suggestion.

IMHO, there's no point to track debug build's crash because we can always collect and read crash stack trace in debug build without the need of Firebase.

What do you think? @kirillt @shubertm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right @tuancoltech

Copy link
Member

@shubertm shubertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tuancoltech tuancoltech merged commit 6366e44 into feature/new_ui_design Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants