Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batch deletion #70

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Support batch deletion #70

merged 7 commits into from
Nov 28, 2024

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Aug 4, 2024 •
edited
Loading

Description:

Support batch deletion: #47

Screenshots:

Screenshot 2024-08-04 at 15 13 12 Screenshot 2024-08-04 at 15 13 27

@tuancoltech tuancoltech self-assigned this Aug 4, 2024
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 4 times, most recently from a49cb91 to 5cecfff Compare August 4, 2024 15:06
@tuancoltech tuancoltech mentioned this pull request Aug 4, 2024
Closed
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 2 times, most recently from c4c3c8c to 6342290 Compare August 8, 2024 15:07
@tuancoltech tuancoltech force-pushed the feature/new_ui_design branch from d58496a to 5419bb4 Compare August 11, 2024 15:20
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from 6342290 to a3266d3 Compare September 3, 2024 05:21
@tuancoltech tuancoltech force-pushed the feature/new_ui_design branch 2 times, most recently from 90410db to 8df7cee Compare September 9, 2024 05:52
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 3 times, most recently from 4752e78 to c0ec632 Compare September 21, 2024 03:15
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from c0ec632 to 524cbce Compare September 27, 2024 05:33
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 2 times, most recently from 10c794a to c0d8998 Compare October 9, 2024 14:44
@shubertm shubertm self-requested a review October 22, 2024 11:03
shubertm
shubertm requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@shubertm shubertm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVID_20241022_213104_1.mp4

  • Long click must select the item

  • Back button should deselect all

  • Switch off screen after selection and all checked states are lost

SVID_20241023_153320_1.mp4
  • Ripple should have shape of the note item. Observe carefully

@tuancoltech tuancoltech changed the base branch from feature/new_ui_design to main October 25, 2024 05:38
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from c0d8998 to 78aa757 Compare October 25, 2024 05:41
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from c0ef5dd to b85a4ac Compare October 26, 2024 15:47
@tuancoltech tuancoltech changed the title WIP: Support batch deletion Support batch deletion Oct 26, 2024
@shubertm shubertm closed this Nov 15, 2024
@shubertm shubertm deleted the feat/support_batch_deletion_v2 branch November 15, 2024 16:53
@shubertm shubertm restored the feat/support_batch_deletion_v2 branch November 15, 2024 16:54
@shubertm shubertm reopened this Nov 15, 2024
@tuancoltech
Copy link
Collaborator Author

SVID_20241114_062853_1.mp4

  • Ripple goes below extra view on notes with previews. In other versions it is ok

@shubertm I haven't been clear what the issue is.
Do you mean, the ripple is partially below the graphic thumb, while it should be on top of it?

@shubertm
Copy link
Member

SVID_20241114_062853_1.mp4

  • Ripple goes below extra view on notes with previews. In other versions it is ok

@shubertm I haven't been clear what the issue is. Do you mean, the ripple is partially below the graphic thumb, while it should be on top of it?

Yes, exactly

@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from 4775613 to 0ccf11d Compare November 23, 2024 03:43
@tuancoltech
* Show empty state of notes list when all notes are deleted
4f94243 
* Fix a bug in selecting notes for deletion logic
@tuancoltech tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from 0ccf11d to 4f94243 Compare November 23, 2024 04:16
@tuancoltech
Copy link
Collaborator Author

SVID_20241114_062853_1.mp4

  • Ripple goes below extra view on notes with previews. In other versions it is ok

@shubertm I haven't been clear what the issue is. Do you mean, the ripple is partially below the graphic thumb, while it should be on top of it?

Yes, exactly

@shubertm It's fixed. Please check again.

shubertm
shubertm approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@shubertm shubertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tuancoltech
Copy link
Collaborator Author

Looks good

@shubertm Have you done with QA?

@shubertm
Copy link
Member

Looks good

@shubertm Have you done with QA?

QA not done, wait for the label

@tuancoltech tuancoltech merged commit 8d48ed4 into main Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubertm shubertm shubertm approved these changes

@hieuwu hieuwu Awaiting requested review from hieuwu

Assignees

@tuancoltech tuancoltech

Labels
do not merge enhancement New feature or request feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuancoltech @shubertm