#21: The app becomes unusable if user closes folder selection dialog #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shubertm
commented
Dec 5, 2023
•
shubertm
commented
- The app becomes unusable if user closes folder selection dialog #21
tuancoltech
reviewed
Dec 6, 2023
Comment on lines
22
to
24
| val activity = (requireActivity() as MainActivity) | ||
| if (activity.memoPreferences.getPathString() == null) activity.finish() | ||
| } |
There was a problem hiding this comment.
Assuming FilePickerDialog might probably be used in other activity in the future, rather than MainActivity, this casting will cause a crash.
What do you think about below?
Suggested change
| val activity = (requireActivity() as MainActivity) | |
| if (activity.memoPreferences.getPathString() == null) activity.finish() | |
| } | |
| val activity = (activity as? MainActivity) | |
| if (activity?.memoPreferences?.getPathString() == null) activity?.finish() | |
| } |
tuancoltech
reviewed
Dec 6, 2023
| fun show() { | ||
| ArkFilePickerFragment.newInstance(getFilePickerConfig()).show(fragmentManager!!, TAG) | ||
| newInstance(getFilePickerConfig()).show(fragmentManager!!, TAG) |
There was a problem hiding this comment.
Suggested change
| newInstance(getFilePickerConfig()).show(fragmentManager!!, TAG) | |
| fragmentManager?.let { newInstance(getFilePickerConfig()).show(it, TAG) } |
There was a problem hiding this comment.
I think fragmentManager can not really be null here. We can just make it non-nullable
|
Doesn't look fixed: bug.mp4It's possible to close the app and start it again, but it works the same way in other branches. The best would be to disable touching outside the filepicker. |
* SVG generating * Fix gradle build and deprecated APIs * Move local texts to string resource file * Add extended fab * Generalize file listing function * Fix extra line feed in text content Co-authored-by: Tuan Nguyen <tuancoltech@gmail.com>
Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.8.9 to 2.10.1. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/main/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.9...gson-parent-2.10.1) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Cool |
# Conflicts: # app/src/main/java/dev/arkbuilders/arkmemo/ui/activities/MainActivity.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/dialogs/FilePickerDialog.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.