[PHP 7.3] compact() issues an E_NOTICE level error

[drbyte]

• LogViewer Version: 4.6.0
• Laravel Version: 5.7.2
• PHP Version: 7.3.0-beta-2
• Hosted locally on Laravel Valet

Description:

Trying to compact a non-defined variable.

LogViewer/src/Http/Controllers/LogViewerController.php

Lines 82 to 89 in a8cd768

	public function listLogs(Request $request)
	{
	$stats = $this->logViewer->statsTable();
	$headers = $stats->header();
	$rows = $this->paginate($stats->rows(), $request);
	return $this->view('logs', compact('headers', 'rows', 'footer'));
	}

Steps To Reproduce:

Followed @arcanedev-maroc instructions in #195 (comment)

composer create-project laravel/laravel fresh-laravel && cd fresh-laravel
composer require arcanedev/log-viewer
// set LOG_CHANNEL=daily
php artisan log-viewer:publish

Added logging to route:

Route::get('/', function () {
    Log::info('This is info log');

    return view('welcome');
});

• Visit URL to create some logs
• Visit log-viewer URL: http://fresh-laravel.test/log-viewer
• Click on the "Logs" link. Get error: compact(): Undefined variable: footer

[drbyte]

Note: same problem exists with search in

LogViewer/src/Http/Controllers/LogViewerController.php

Lines 98 to 105 in a8cd768

	public function show($date)
	{
	$log = $this->getLogOrFail($date);
	$levels = $this->logViewer->levelsNames();
	$entries = $log->entries($level = 'all')->paginate($this->perPage);
	return $this->view('show', compact('log', 'levels', 'level', 'search', 'entries'));
	}

and

LogViewer/src/Http/Controllers/LogViewerController.php

Lines 115 to 126 in a8cd768

	public function showByLevel($date, $level)
	{
	$log = $this->getLogOrFail($date);
	if ($level === 'all')
	return redirect()->route($this->showRoute, [$date]);
	$levels = $this->logViewer->levelsNames();
	$entries = $this->logViewer->entries($date, $level)->paginate($this->perPage);
	return $this->view('show', compact('log', 'levels', 'level', 'search', 'entries'));
	}

[drbyte]

Note: after swapping footer with stats, and search with date, the view still contains another compact() call to query, which doesn't exist either:

LogViewer/resources/views/bootstrap-4/show.blade.php

Line 163 in a8cd768

{!! $entries->appends(compact('query'))->render() !!}

[arcanedev-maroc]

This is why:

Note:
Before PHP 7.3, any strings that are not set will silently be skipped.

Changelog

Version	Description
7.3.0	compact() now issues an E_NOTICE level error if a given string refers to an unset variable. Formerly, such strings have been silently skipped.

Source: https://secure.php.net/manual/en/function.compact.php

PHP 7.3 is not supported for the time being but it's good to know 👍

Feel free to make a PR

[HDVinnie]

Just replace usages of compact()

return $this->view('logs', compact('headers', 'rows', 'footer'));

TO

return $this->view('logs', ['headers' => $headers, 'rows' => $rows, 'footer' => $footer]);

OR

return $this->view('logs')->with('headers' => $headers, 'rows' => $rows, 'footer' => $footer);

[drbyte]

@arcanedev-maroc no, this isn't a PHP 7.3 issue.

It's bugs that were created in #153 when refactoring was done which relocated some variables but didn't update the variables passed to compact, and changes were made to views.

See PR #242

[arcanedev-maroc]

Patch released: v4.6.1