Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces optimist with minimist because optimist is no longer maintained and has a security issue related to an older version of minimist. See #133
francescarpi It looks like the tests doesn't cover the import and export scripts so i was not able to test it. Also i am not familiar with redux-i18n so i didn't add new tests. On the other hand i checked with a node script that the behaviour of the two libraries are the same.
then i ran
node index.js --foo bar hello world
output:
The only difference is see is $0 property in the optimist version which is missing in minimist. I am not sure about if this is an issue or if this information is not needed for redux-i18n