fix: use react forceUpdate instead of deep-force-update #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abanobgeorges
approved these changes
Jul 13, 2021
clecho
approved these changes
Jul 13, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a bug which only occurred in production build. (react-script build && serve -s build). If i had to rerender I18n component due to a setLanguage it would crash the application. The error occurend on this line in react-deep-force-update package. (root was undefined).
The error:
I wrote a new Component which use React forceUpdate method and it worked like a charm. Feel free to use it, might save a day or two for the next one.