Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React.forwardRef(), React.memo() and latest react-redux. #103

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented Jul 9, 2019

Components aren't always just functions. For example React.forwardRef() returns an object.

Other libraries like react-redux use the official react package react-is to verify that the passed value is a valid element type.

@topaxi
Copy link
Contributor Author

topaxi commented Aug 5, 2019

This is also needed to work with the newest react-redux connect() function.

@topaxi topaxi changed the title Support React.forwardRef() Support React.forwardRef(), React.memo() and latest react-redux. Sep 24, 2019
@francescarpi francescarpi merged commit ccc2f34 into APSL:master Oct 21, 2019
@francescarpi
Copy link
Member

Thanks

@topaxi topaxi deleted the support-forward-ref branch October 22, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants