Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Babel 6 #8

Closed
drewtunes opened this issue Dec 1, 2015 · 9 comments
Closed

Support Babel 6 #8

drewtunes opened this issue Dec 1, 2015 · 9 comments

Comments

@drewtunes
Copy link

React Native 0.16.0-rc uses Babel 6 so this would be nice. I'm not sure how much work that is to do.

@alvaromb
Copy link
Collaborator

alvaromb commented Dec 2, 2015

Hi @cava23!!

Let me know if this PR #9 works for you and I'll merge it and make a release.

@alvaromb
Copy link
Collaborator

alvaromb commented Dec 2, 2015

I think it's the best solution right now (take a look at this issue reduxjs/redux#1033), but keep in mind that the component is written un ES6 style so you should configure your own .babelrc in order to make it working.

@drewtunes
Copy link
Author

Thanks for the PR. Unfortunately, I’m still having trouble. react-native-button pulls in it’s own version of react-native since I guess 0.16.0-rc doesn’t satisfy the dependency. I’m wondering if that’s an npm bug. I’m just going back to 0.15.0 for now. Uhhggg.

On Dec 2, 2015, at 12:50 AM, Álvaro Medina Ballester notifications@github.com wrote:

I think it's the best solution right now (take a look at this issue reduxjs/redux#1033 reduxjs/redux#1033), but keep in mind that the component is written un ES6 style so you should configure your own .babelrc in order to make it working.


Reply to this email directly or view it on GitHub #8 (comment).

@drewtunes
Copy link
Author

Changing the last line of Button.js to:
module.exports = Button;
got it working on 0.16.0-rc.

On Dec 2, 2015, at 10:09 AM, Andrew Crowell andrewj.crowell@gmail.com wrote:

Thanks for the PR. Unfortunately, I’m still having trouble. react-native-button pulls in it’s own version of react-native since I guess 0.16.0-rc doesn’t satisfy the dependency. I’m wondering if that’s an npm bug. I’m just going back to 0.15.0 for now. Uhhggg.

On Dec 2, 2015, at 12:50 AM, Álvaro Medina Ballester <notifications@github.com mailto:notifications@github.com> wrote:

I think it's the best solution right now (take a look at this issue reduxjs/redux#1033 reduxjs/redux#1033), but keep in mind that the component is written un ES6 style so you should configure your own .babelrc in order to make it working.


Reply to this email directly or view it on GitHub #8 (comment).

@alvaromb
Copy link
Collaborator

alvaromb commented Dec 3, 2015

That's strange. I'm going to change the ES6 style and make a release. Once it's done, let me know if it works for you.

@alvaromb
Copy link
Collaborator

alvaromb commented Dec 3, 2015

@cava23 keep in mind that the PR hasn't been merged yet, so if you want to try it you should install from it's own branch.

@alvaromb
Copy link
Collaborator

alvaromb commented Dec 3, 2015

Just pushed https://github.com/APSL/react-native-button/releases/tag/v2.3.0. Let me know if it works for you!

@alvaromb alvaromb closed this as completed Dec 3, 2015
@drewtunes
Copy link
Author

That worked! Thanks.

On Dec 3, 2015, at 2:15 AM, Álvaro Medina Ballester notifications@github.com wrote:

Closed #8 #8.


Reply to this email directly or view it on GitHub #8 (comment).

@drewtunes
Copy link
Author

btw, this commit facebook/react-native@dff8f53 facebook/react-native@dff8f53 fixes the issue with ES6 module export.

On Dec 3, 2015, at 6:23 PM, Andrew Crowell andrewj.crowell@gmail.com wrote:

That worked! Thanks.

On Dec 3, 2015, at 2:15 AM, Álvaro Medina Ballester <notifications@github.com mailto:notifications@github.com> wrote:

Closed #8 #8.


Reply to this email directly or view it on GitHub #8 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants