Update all signs (#670)

APDevTeam · Jul 21, 2024 · d5627a9 · d5627a9
1 parent 6c2f22f
commit d5627a9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/Movecraft/src/main/java/net/countercraft/movecraft/mapUpdater/update/CraftRotateCommand.java b/Movecraft/src/main/java/net/countercraft/movecraft/mapUpdater/update/CraftRotateCommand.java
@@ -227,6 +227,11 @@ public boolean equals(String[] a, String[] b) {
         for (Map.Entry<String[], List<MovecraftLocation>> entry : signs.entrySet()) {
             SignTranslateEvent event = new SignTranslateEvent(craft, entry.getKey(), entry.getValue());
             Bukkit.getServer().getPluginManager().callEvent(event);
+            // if(!event.isUpdated()){
+            //     continue;
+            // }
+            // TODO: This is implemented only to fix client caching
+            //  ideally we wouldn't do the update and would instead fake it out to the player
             for (MovecraftLocation location : entry.getValue()) {
                 Block block = location.toBukkit(craft.getWorld()).getBlock();
                 BlockState state = block.getState();

diff --git a/...aft/src/main/java/net/countercraft/movecraft/mapUpdater/update/CraftTranslateCommand.java b/...aft/src/main/java/net/countercraft/movecraft/mapUpdater/update/CraftTranslateCommand.java
@@ -333,9 +333,11 @@ public boolean equals(String[] a, String[] b) {
         for(Map.Entry<String[], List<MovecraftLocation>> entry : signs.entrySet()){
             SignTranslateEvent event = new SignTranslateEvent(craft, entry.getKey(), entry.getValue());
             Bukkit.getServer().getPluginManager().callEvent(event);
-            if(!event.isUpdated()){
-                continue;
-            }
+            // if(!event.isUpdated()){
+            //     continue;
+            // }
+            // TODO: This is implemented only to fix client caching
+            //  ideally we wouldn't do the update and would instead fake it out to the player
             for(MovecraftLocation location : entry.getValue()){
                 Block block = location.toBukkit(craft.getWorld()).getBlock();
                 BlockState state = block.getState();