Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'Enter Country' Field Validation #30

Merged

Conversation

bibekkd
Copy link

@bibekkd bibekkd commented Mar 10, 2025

Title: 🛠 Restricted 'Enter Country' Input to Valid Country Names [feature/country-field-validation]


📌 Description:

This PR fixes the issue where the ‘Enter Country’ field in BasicDetailsScreen.jsx was accepting invalid inputs. Instead of allowing free text entry, I have implemented a selectable country list in a modal view, ensuring users can only select valid countries.


🔄 Changes Made:

  • ✅ Replaced text input with a selectable country list.
  • ✅ Implemented a modal view that displays a list of valid countries.
  • ✅ Ensured that users can only select a country from the list.
  • ✅ Improved UI/UX by making country selection more intuitive.

🔗 Linked Issue:

Closes #29


🎯 Benefits:

  • ✔️ Prevents users from entering invalid country names.
  • ✔️ Enhances data accuracy by ensuring only real countries are selected.
  • ✔️ Provides a better user experience with a guided selection process.

🎥 Before & After Video Evidence

  • 📌 Before Fix:
Frontend.recording.2025-03-11.01.49.21.mp4
  • 📌 After Fix:
Frontend.recording.2025-03-11.02.10.51.mp4

🛠 Testing:

  • Verified that only valid countries can be selected.
  • Tested on different screen sizes to ensure UI consistency.
  • Ensured the modal view works smoothly for selecting countries.

📜 Commit Message:

git commit -m "Fix [feature/country-field-validation]: Restricted 'Enter Country' input to valid country selection (#29)"

@bhavik-mangla
Copy link
Contributor

good

@bhavik-mangla
Copy link
Contributor

@bibekkd try solving issues #20 #7

@bibekkd
Copy link
Author

bibekkd commented Mar 10, 2025

I am going for this

@bhavik-mangla bhavik-mangla merged commit 0059b51 into AOSSIE-Org:main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicDetailsScreen: 'Enter Country' Field Accepts Invalid Input
2 participants