[fix]: Fix assert bug related to DNDEBUG flags #527 #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add function aio::doAssert to replace asserts Did not use aio::assert as name since aio.h namespace complains due to assert being a macro Fixes the major bug explained in #527 Fixes issues #520 #474 #466 #420 #405 #396 #385 Possibly others; other issues should rerun the commands using the latest version.
ASSERT macro replaces expressions inplace so that if expression failed do aio::assertFailed with expression text and AT. Update doAssert to function the same way as assert macro. Update all assert statements including misc
[chore] Merge master to branch
…d/angsd into fixassert_isinaltinkaya_221008_1207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function aio::doAssert and macro ASSERT to replace asserts.
Fixes #527 which explains the bug about conda adding
-DNDEBUGflag thus disabling the assert statements.Fixes #520; fixes #474; fixes #466; fixes #420; fixes #405; fixes #396; fixes #385.
Possibly others too; so other issues should rerun the commands using the latest version.