Skip to content

Commit

Permalink
Fix vis-augmenter forming empty key-value pairs in its calls to the s…
Browse files Browse the repository at this point in the history
…avedObject API

Fixes opensearch-project#5187

Signed-off-by: Miki <miki@amazon.com>
  • Loading branch information
AMoo-Miki committed Oct 3, 2023
1 parent cb6e0f0 commit 977a106
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/plugins/vis_augmenter/public/utils/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,19 @@ export const getAugmentVisSavedObjs = async (
);
}
try {
// If there is specified plugin resource IDs, add a search string and search field
// into findAll() fn call
// If there are any plugin resource IDs specified, add a search string and search field
// into findAll() call
const pluginResourceIdsSpecified =
pluginResourceIds !== undefined && pluginResourceIds.length > 0;
Array.isArray(pluginResourceIds) && pluginResourceIds.length > 0;
const resp = await loader?.findAll(
pluginResourceIdsSpecified ? pluginResourceIds.join('|') : '',
pluginResourceIdsSpecified ? pluginResourceIds!.join('|') : '',
100,
[],
undefined,
{
type: 'visualization',
id: visId as string,
},
pluginResourceIdsSpecified ? ['pluginResource.id'] : []
pluginResourceIdsSpecified ? ['pluginResource.id'] : undefined
);
return (get(resp, 'hits', []) as any[]) as ISavedAugmentVis[];
} catch (e) {
Expand Down

0 comments on commit 977a106

Please sign in to comment.