Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS0501Test.py: remove trailing slash from /staged endpoint for PATCH #856

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthewdicken
Copy link

per https://specs.amwa.tv/is-05/releases/v1.1.2/docs/Controllers.html

Controllers performing requests other than GET or HEAD (i.e PUT, POST, DELETE, OPTIONS etc.) MUST use URLs with no trailing slash present.

Currently, test_11_02 and test_12_02 will fail on a node that returns 405: method not allowed for a PATCH on the /staged/ endpoint

@garethsb
Copy link
Contributor

Thanks, @matthewdicken, agree the PATCH request should not have a trailing slash.

The code looks a bit weird with this change, and it also affects the GET request that happens before the PATCH. However, this test suite already has a mix between making GET requests with/without the trailing slash. Generally the GET requests have it and in at least one test case (test_21) the code goes out of the way to issue PATCH without, and GET with. However in one or two places, a GET request is made without the trailing slash.

I say merge this and come back later if we want to consistently test GET requests with/without trailing slash (or both).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants