Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for warnings in 2D #534

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

baperry2
Copy link
Contributor

@baperry2 baperry2 commented Oct 7, 2024

Some capabilities (TurbInflow, DiagFramePlane) are only implemented for 3D. Compile warnings can come up for 2D because the implementations index in the 3rd element of data structures that are AMREX_SPACEDIM in size.

This PR:

  • Raises errors if trying to use unsupported capability in a 2D simulation
  • Slightly modifies the implementations to remove indexing that leads to compiler warnings in 2D
  • Deletes some #if 0 debugging code from the turbinflow capability and instead adds an option for more verbose output

@baperry2 baperry2 requested a review from marchdf October 7, 2024 21:56
@baperry2 baperry2 merged commit 862c29c into AMReX-Combustion:development Oct 8, 2024
10 checks passed
@baperry2 baperry2 deleted the intvect-fixes branch October 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants