Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amrex #518

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Update amrex #518

merged 2 commits into from
Aug 5, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Aug 5, 2024

No description provided.

@marchdf marchdf requested a review from baperry2 August 5, 2024 19:30
Copy link
Contributor

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While doing this, let's also roll back #510 to address the issue described in AMReX-Combustion/PeleC#830 and get dependabot updates working again. (see here for log of dependabot failure, I believe, but have not confirmed, that this is occurring because of the shwllow submodule clones: https://github.com/AMReX-Combustion/PelePhysics/network/updates/863923305).

Due to a bug in git (git/git#1740), the default shallow clones are not saving us that much download size anyway.

@marchdf marchdf enabled auto-merge (squash) August 5, 2024 20:09
@marchdf marchdf merged commit 5b31268 into development Aug 5, 2024
9 checks passed
@marchdf marchdf deleted the update-amrex branch August 5, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants