-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the sundials submodule for make TPL #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that users compiling the PelePhysics tests with GNUmake after this PR will need to clone their own copy of Sundials and specify the path using the SUNDIALS_HOME
in the GNUmakefile
for the case (in addition to cloning AMReX and setting AMREX_HOME
).
We should really have that documented somewhere, but don't really have anything on these test cases, so that's a much bigger task beyond the scope of this PR.
We could check if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of using wget as a back up, but what's there now is also fine.
No description provided.