Refactor turbulence inflow #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
force-pushed
the
turb-refactor
branch
from
d7255b6
to
352ef26
Compare
|
Mohammad tested this out and it seems to work. I think @esclapez is doing the same on the LM side.
|
esclapez
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the turbulence inflow, encapsulates it better, makes it more modular. The user will have to switch to a new PP querry prefix (
turbinflowinstead ofprob).@esclapez can you give this a shot on a problem that works for you in LM? You can see what I did to PeleC in the PR referred below.