-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable isothermal EB specification #84
Conversation
Conflicts: Source/PeleLMEB.cpp
not convinced it works better.
|
Conflicts: Source/PeleLMDiffusion.cpp Source/PeleLMUtils.cpp Source/PeleLM_K.H
Conflicts: Source/PeleLMDiffusion.cpp Source/PeleLMEB.cpp Source/PeleLMUtils.cpp Source/PeleLM_K.H
…soT_EB Conflicts: Source/PeleLMDiffusion.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I tried one of the test cases and the results looked qualitatively reasonable
Docs/source/manual/LMeXControls.rst
Outdated
@@ -231,14 +264,14 @@ The `eb2.small_volfrac` controls volume fraction that are deemed too small and e | |||
This operation is done iteratively and the maximum number of iteration is prescribed by `eb2.maxiter`. | |||
For most applications, a single AMReX object is insufficient to represent the geometry. AMReX enable to combine | |||
objects using constructive solid geometry (CSG) in order to create complex geometry. It is up to the user to define | |||
the combination of basic elements leading to its desired geometry. To switch to a user-defined EB definition, one | |||
the combination of basic elements leading to his desired geometry. To switch to a user-defined EB definition, one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "the user" to "users" and "his" to "their"
xcell[2] + ebfc_z(i,j,k) * dx[2])}; | ||
amrex::Real ebflagtype = 0.0; | ||
setEBType(xface, ebflagtype, geomdata, *lprobparm); | ||
ebdiff(i,j,k) = diff_cc(i,j,k) * ebflagtype; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that if running with an LES model this will only get the molecular component of the thermal diffusivity because the turbulent component is added when moving from cc to fc. I believe this behavior is the same for how the no slip condition on EBs is presently implemented, and is fine. If using WALE and enough resolution at the boundaries the turbulent part should go to 0 anyway, and if not then we'd want to add a wall model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. It's probably worth adding a note in the doc for that.
At this point, activating isothermal EB with
peleLM.isothermal_EB = 1
set the entire EB as Dirichlet, the value of which then needs to be specified by thesetEBState
function, added to pelelm_prob.H.See Exec/Regtests/EB_FlowPastCylinder for an implementation example.