Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #267

Merged
merged 10 commits into from
Sep 27, 2023
Merged

Fix warnings #267

merged 10 commits into from
Sep 27, 2023

Conversation

jrood-nrel
Copy link
Contributor

No description provided.

Comment on lines +55 to +61
// if (useUMac) {
// // TODO: find a way to get U^{n+1/2} from Umac
// // For now get old time
// Real oldtime = getTime(lev,AmrOldTime);
// fillpatch_velocity(lev, oldtime, m_leveldata_floating->state, VELX,
// m_nGrowState);
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@@ -25,7 +25,7 @@
pele::physics::PMF::PmfData::DataContainer const* /*pmf_data*/)
{
const amrex::Real* prob_lo = geomdata.ProbLo();
const amrex::Real* prob_hi = geomdata.ProbHi();
// const amrex::Real* prob_hi = geomdata.ProbHi();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

state(i, j, k, TEMP) = prob_parm.T_mean;
// Set up the Gaussian as the solution of the diffusion of a delta dirac
// initial distribution after time gaussTime of a diffusion process with
// constant diffusion coeff. gaussDiff. Use ampgauss to avoid
// undershoot/overshoot of the 2-species mixture.
const amrex::Real deltax = x - prob_parm.xgauss;
const amrex::Real deltay = y - prob_parm.ygauss;
// const amrex::Real deltay = y - prob_parm.ygauss;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
, const amrex::Real y = prob_lo[1] + (j + 0.5) * dx[1];
, const amrex::Real z = prob_lo[2] + (k + 0.5) * dx[2];);
, const amrex::Real y = prob_lo[1] + (j + 0.5) * dx[1];,
/*const amrex::Real z = prob_lo[2] + (k + 0.5) * dx[2];*/);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@@ -33,11 +33,9 @@
, const amrex::Real z = prob_lo[2] + (k + 0.5) * dx[2];);

AMREX_D_TERM(const amrex::Real Lx = prob_hi[0] - prob_lo[0];
, const amrex::Real Ly = prob_hi[1] - prob_lo[1];
, /*const amrex::Real Ly = prob_hi[1] - prob_lo[1];*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +163 to +165
// const amrex::Real* prob_lo = geomdata.ProbLo();
// const amrex::Real* prob_hi = geomdata.ProbHi();
// const amrex::Real* dx = geomdata.CellSize();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +92 to +94
// const amrex::Real* prob_lo = geomdata.ProbLo();
// const amrex::Real* prob_hi = geomdata.ProbHi();
// const amrex::Real* dx = geomdata.CellSize();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@jrood-nrel jrood-nrel marked this pull request as ready for review September 26, 2023 20:24
@jrood-nrel jrood-nrel enabled auto-merge (squash) September 26, 2023 20:24
@@ -603,7 +601,7 @@
Ted_arr);
});

auto const& rhoY = rhoY_ed.const_array(0);
// auto const& rhoY = rhoY_ed.const_array(0);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@jrood-nrel jrood-nrel merged commit da066c5 into development Sep 27, 2023
13 of 19 checks passed
@jrood-nrel jrood-nrel deleted the jrood/warnings branch September 27, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants