Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming LM -> LMeX #257

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Renaming LM -> LMeX #257

merged 1 commit into from
Sep 21, 2023

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Sep 19, 2023

No description provided.

@baperry2
Copy link
Collaborator

@marchdf
Copy link
Contributor Author

marchdf commented Sep 20, 2023

yikes good catch. Wondering if this is a good idea... I did a second pass and I think I caught a bunch more. There's still the input files though... they use controls like PeleLM.. But maybe that's ok? Or we break everyone's input file.

@marchdf
Copy link
Contributor Author

marchdf commented Sep 20, 2023

Looks like I need AMReX-Combustion/PelePhysics#422 first because AMReX-Combustion/PelePhysics#417 broke some things.

Copy link
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One consideration would be that we don't want to add friction to remaining LM users transitioning from LM to LMeX now that LM is no longer being supported. But I don't think this adds much to that burden. But I agree, let's not change the parmparse prefix.

@marchdf marchdf marked this pull request as ready for review September 21, 2023 14:19
@marchdf marchdf enabled auto-merge (squash) September 21, 2023 14:19
@marchdf marchdf merged commit 5487435 into development Sep 21, 2023
16 of 19 checks passed
@marchdf marchdf deleted the renaming branch September 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants