Fix DiagFramePlane diagnostic #190
Conversation
|
Nice. I ran into the issue with ghost cells on the Sydney flame case and worked around it by turning off interpolation. I'll test this fix on that case to make sure it works with interpolation now. One more thing with diagnostics that I ran into is that if there is a derived variable with multiple components, you have to call out the individual component names rather than the derive name. I was going to look into relaxing that requirement. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I've been looking at this, and it might be tricky to get the diagnostics to interact with the derived because the intent was to have the diagnostics be as separate as possible in order to move them to PeleAnalysis at some point. I'll try something. |
It's not a big issue because one can simply list out all the components if desired. But it would be good to throw an error if someone requests a multi-component derive rather than the individual component, because right now that case is not handled properly. |
in the Diagnostics.
Source/PeleLMDiagnostics.cpp
Outdated
| } else { | ||
| if (derive_lst.canDerive(v)) { | ||
| const PeleLMDeriveRec* rec = derive_lst.get(v); | ||
| if (rec->numDerive() > 1) { |
There was a problem hiding this comment.
This will capture when people request the individual derive components as well. The condition rec->variableComp(v) < 0 should work to throw an error for the full multi-component derive but not the individual components.
There was a problem hiding this comment.
Indeed ! Good catch !
No description provided.