Add the TaylorGreen vortex breakdown case from PeleC #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
esclapez
commented
Jul 5, 2022
esclapez
commented
- add TG RegTests with processing scripts
- initiate validation section of the doc with results from TG
ldowen
reviewed
Jul 6, 2022
| const amrex::Real Ly = prob_hi[1] - prob_lo[1];, | ||
| const amrex::Real Lz = prob_hi[2] - prob_lo[2]); | ||
|
|
||
| AMREX_D_TERM(const amrex::Real x_c = prob_lo[0] + 0.5*Lx;, |
There was a problem hiding this comment.
These don't seem to be used.
ldowen
reviewed
Jul 6, 2022
| const amrex::Real z_c = prob_lo[2] + 0.5*Lz); | ||
|
|
||
| auto eos = pele::physics::PhysicsType::eos(); | ||
| constexpr amrex::Real Pi = 3.14159265358979323846264338327950288; |
ldowen
reviewed
Jul 6, 2022
| amrex::Real u[3] = {0.0}; | ||
| u[0] = prob_parm.v0 * sin(prob_parm.omega_x * x / prob_parm.L) * | ||
| cos(prob_parm.omega_y * y / prob_parm.L) * | ||
| cos(prob_parm.omega_z * z / prob_parm.L); |
There was a problem hiding this comment.
Only potential issue is that z won't be known if we are compiling in 2D. Not sure if that matters though.
There was a problem hiding this comment.
It's not a case intended for 2D, but it's worth making it possible to compile anyway, good point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.