-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the TaylorGreen vortex breakdown case from PeleC #106
Conversation
esclapez
commented
Jul 5, 2022
- add TG RegTests with processing scripts
- initiate validation section of the doc with results from TG
const amrex::Real Ly = prob_hi[1] - prob_lo[1];, | ||
const amrex::Real Lz = prob_hi[2] - prob_lo[2]); | ||
|
||
AMREX_D_TERM(const amrex::Real x_c = prob_lo[0] + 0.5*Lx;, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't seem to be used.
const amrex::Real z_c = prob_lo[2] + 0.5*Lz); | ||
|
||
auto eos = pele::physics::PhysicsType::eos(); | ||
constexpr amrex::Real Pi = 3.14159265358979323846264338327950288; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would M_PI
work instead?
amrex::Real u[3] = {0.0}; | ||
u[0] = prob_parm.v0 * sin(prob_parm.omega_x * x / prob_parm.L) * | ||
cos(prob_parm.omega_y * y / prob_parm.L) * | ||
cos(prob_parm.omega_z * z / prob_parm.L); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only potential issue is that z
won't be known if we are compiling in 2D. Not sure if that matters though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a case intended for 2D, but it's worth making it possible to compile anyway, good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!