Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle mkd only #103

Merged
merged 6 commits into from
Jun 30, 2022
Merged

Particle mkd only #103

merged 6 commits into from
Jun 30, 2022

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Jun 29, 2022

This PR adds:

  • An assert to ensure dx[0] == dx[1] == dx[2]
  • Changes spray droplet updates from to only doing a single move-kick-drift operation. Prior to this PR, the move-kick-drift operation updated the particle variables to dt/2 and the position to dt. Then a move-kick operation used the gas phase data at dt to update the particle variables to dt. Now, the move-kick-drift updates the particle position and variables to dt in one call. For particle CFL values greater than 0.5, this method is results in more consistent contributions to the gas phase. It also requires fewer redistribute calls.
  • Removed unnecessary resetting of external source MultiFabs.

Landon Owen added 3 commits June 29, 2022 16:33
…external sources, removed sprayMK functions so only 1 spray update is used per timestep
@ldowen ldowen requested a review from esclapez June 29, 2022 23:59
@esclapez esclapez merged commit b449359 into development Jun 30, 2022
@esclapez esclapez deleted the particle_mkd_only branch June 30, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants