Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove advection from auxiliary quantities B_k #839

Merged
merged 22 commits into from
Sep 5, 2024
Merged

Remove advection from auxiliary quantities B_k #839

merged 22 commits into from
Sep 5, 2024

Commits on Aug 30, 2024

  1. 1) Fixed minor typo in FlowPastCylinder documentation. 

    2) Updated the auxiliary quantities (B_k in documented equations) so that they are no longer advected. We believe that these equations are identical to the advected quantities.  The new auxiliary quantities provide the option to include state variables that are stationary in space.
3) Added a test case that verifies the new B_k equations work with MOL, Godunov, and EB's.
    @dmontgomeryNREL
    dmontgomeryNREL committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a48bcf9 View commit details
    Browse the repository at this point in the history

  2. Included density in the source term for the auxiliary quantities.

    @dmontgomeryNREL
    dmontgomeryNREL committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4596655 View commit details
    Browse the repository at this point in the history

  3. Updated README.md

    @dmontgomeryNREL
    dmontgomeryNREL committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    1233c01 View commit details
    Browse the repository at this point in the history

  4. Updated README.md.

    @dmontgomeryNREL
    dmontgomeryNREL committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b1d7577 View commit details
    Browse the repository at this point in the history

  5. Updated README.md.

    @dmontgomeryNREL
    dmontgomeryNREL committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    14213cf View commit details
    Browse the repository at this point in the history

  6. Updated the equations in the documentation for the auxiliary quantities.

    @dmontgomeryNREL
    dmontgomeryNREL committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a1209f5 View commit details
    Browse the repository at this point in the history

  7. Formated using clang-format. Cleaned up input files and updated Equat… 

    …ions.rst in documentation.
    @dmontgomeryNREL
    dmontgomeryNREL committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fb7cae4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Fixed typo in comment.

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d27aab2 View commit details
    Browse the repository at this point in the history

  2. Added auxquantities_eb to the CI.

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ee63c1e View commit details
    Browse the repository at this point in the history

  3. Updated the strength of the source term so the B_k's decay faster. St… 

    …ill seeing some "transport" around the EB.
    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3053d42 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Added directory for AuxQuantities to Exec/RegTests/CmakeLists.txt

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a915caa View commit details
    Browse the repository at this point in the history

  2. Moved definition of spatial coordinates inside of if statements (e.g.… 

    … #if NUM_AUX > 0). This should ensure that the x variable is not flagged as unused when NUM_AUX or NUM_ADV = 0 during tests.
    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    20b74a7 View commit details
    Browse the repository at this point in the history

  3. clang-format prob.H

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f2e0557 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'development' into rmAdvFromBks

    @dmontgomeryNREL
    dmontgomeryNREL authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9e838b0 View commit details
    Browse the repository at this point in the history

  5. Re-format prob.H

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    eae6bf7 View commit details
    Browse the repository at this point in the history

  6. Re-format prob.H.

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b8a138d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'development' into rmAdvFromBks

    @dmontgomeryNREL
    dmontgomeryNREL authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a963c02 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Removed artificial viscosity from the aux quantities. This fixed the … 

    …issue with diffusion occuring at EB interface.
    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5fd09e1 View commit details
    Browse the repository at this point in the history

  2. Removed unused variable in prob_parm.H, swapped ++n to n++ in a coupl… 

    …e loops in Godunov, set NUM_AUX = NUM_ADV = 2 in CMakeLists.txt for CI tests.
    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    36c9a98 View commit details
    Browse the repository at this point in the history

  3. Auxiliary quantity equation is now d/dt(B_k) = S_{ext,B_k}.

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9e3e7e8 View commit details
    Browse the repository at this point in the history

  4. fix typo in cmake

    @baperry2
    baperry2 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bcccbac View commit details
    Browse the repository at this point in the history

  5. Updated README.md

    @dmontgomeryNREL
    dmontgomeryNREL committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2909b58 View commit details
    Browse the repository at this point in the history