-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PlotFileData bindings #320
Conversation
@BenWibking thanks a lot, looking good! Ping us when you are ready with the unit test and we can include it maybe in this month's release even? |
@ax3l I've added a unit test to read a 3D plotfile with a single level. I put the binary data in the PR, but I can move that to some more appropriate place if needed. When I try to add a test for a 2D plotfile, I get this error:
Do 2D tests need to have some special configuration? |
for more information, see https://pre-commit.ci
@ax3l Aside from the 2D test issue, everything should be working now. |
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This is awesome! I was hoping for this capability. In general, to use pyamrex for pre/postprocessing workflows having as much I/O capability as possible is super helpful. Another example would be reading/writing individual FAB data (appears to be commented out here: pyamrex/src/Base/FArrayBox.cpp Line 38 in 63cae48
|
That would be useful. I'm not sure why that's commented out. Maybe @ax3l knows? In the future, I would like to add the ability to lazy-load FABs for out-of-core analysis, but that might require additional changes in AMReX. |
Awesome, yes those function should be added, too, but maybe in a separate PR. There are some comments in #82 and |
Hi @BenWibking , do you have a chance to finish this for the release slayed for today? :) |
for more information, see https://pre-commit.ci
… add-plotfiledata
@ax3l Thanks for the reminder. Let me know how this looks. |
It looks like the CI failed due to "no disk space left on device":
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! ✨
The CI error is from static code analysis. I think @WeiqunZhang know how we can exclude part of the code (the AMReX part) to get it into the limits of CI? |
Hi @BenWibking, Thank you for your contribution! Please feel free to add yourself to our .zenodo.json so we can credit you in releases. |
Enable reading plotfiles with pyAMReX. Also adds a script in
tools/
to create images from plotfiles.Example use-case: https://github.com/BenWibking/plotfile-viewer.
Closes #317.