CMake: AMReX_BUILD_SHARED_LIBS #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
cmake-build-shared
branch
3 times, most recently
from
9e67ff3 to
0c573a6
Compare
4 tasks
Add a new variable `AMReX_BUILD_SHARED_LIBS` for per-project control of shared lib builds. This variable is more specific (AMReX project) than `BUILD_SHARED_LIBS` (whole build, defaults) and `USE_XSDK_DEFAULTS` (whole build, changed defaults). We need this variable so we can control the AMReX library build in superbuilds without changing all other libraries we build in other projects of the superbuild.
ax3l
force-pushed
the
cmake-build-shared
branch
from
0c573a6 to
c131243
Compare
WeiqunZhang
approved these changes
Nov 9, 2022
5 tasks
|
Ouch, forgot to update the actual |
WeiqunZhang
pushed a commit
that referenced
this pull request
Dec 13, 2022
Forgot to honor the new option. All builds that did not set `BUILD_SHARED_LIBS` were static now. Introduced in #3013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new variable
AMReX_BUILD_SHARED_LIBSfor per-project control of shared lib builds.This variable is more specific (AMReX project) than
BUILD_SHARED_LIBS(whole build, defaults) andUSE_XSDK_DEFAULTS(whole build, changed defaults).We need this variable so we can control the AMReX library build in superbuilds without changing all other libraries we build in other projects of the superbuild.
Additional background
Checklist
The proposed changes: