-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy edge drivers #21
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Give the EA access to a Secret for the driver passwords. This will need to be populated by krbkeys, I think. * Create a Service for the EA broker.
Given that all drivers are deployed identically, and that in general we want to run them on the same host as the edge agent, deploy them as part of the edge agent pod and from the same Helm chart. This does not preclude external drivers, but would need additional configuration to set up external IPs and to listen to the wildcard address.
Include driver images in the `image` values item. Pull them in by name instead of with a full image name. Support defaults for registry and repository. Pass a VERBOSE environment variable to the drivers.
amrc-benmorrow
pushed a commit
that referenced
this pull request
Jul 25, 2024
amrc-benmorrow
pushed a commit
that referenced
this pull request
Jul 25, 2024
amrc-benmorrow
added a commit
that referenced
this pull request
Jul 25, 2024
I'm not sure why I did this in the first place.
amrc-benmorrow
added a commit
that referenced
this pull request
Jul 25, 2024
We were sometimes ending up with an `undefined` flux-system manifest, because cluster-manager had checked out the repo before git had had a chance to act on its auto-pull instructions. Rather than messing about just check out every time. Fix a small bug which occurred when checking out an empty repo, and make sure we refresh our cluster list every 10 minutes in case we miss a ConfigDB update. Fixes: #21 Fixes: #11
This has been merged as part of AMRC-FactoryPlus/amrc-connectivity-stack#316 now that we have brought edge-helm-charts into the ACS monorepo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this only supports on-cluster drivers running in the same Pod as the edge agent. We may want to revisit this decision but for now it seems better to deploy the driver in-pod rather than running separate pods. External (off-cluster, or on-cluster but off-node) drivers could be supported but will need more changes.
This must be merged at the same time as AMRC-FactoryPlus/amrc-connectivity-stack#316 .