Implement modbus driver #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amrc-benmorrow
commented
Jul 17, 2024
amrc-benmorrow
commented
- Implement a driver for testing purposes.
- Implement a modbus-tcp driver. This could be adapted to support modbus-serial fairly straightforwardly.
- Factor out a JS library for writing edge drivers.
This accepts addresses specifying fixed functions. We need to supply a `version` in the address config.
This doesn't handle errors entirely properly yet, but it works.
We need to emit "open" and "close" on the Driver connection, but only if this is a change of status.
This class will only handle drivers which can't do their own polling, and ignore the address groups. Drivers like OPCUA will need a different implementation. This driver is also careful to always poll serially. Some drivers might be able to handle parallel polls, and we should allow this. (Modbus can't.)
We want to maintain a continuous connection to the modbus device. We also want to alert the edge agent promptly if we lose our connection. Handle reconnection via connection events rather than waiting for a poll. Delay 5s before attempting to reconnect, otherwise we may enter a fast loop.
These drivers do not need the GSSAPI code, so should not need our customised base images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.