Fix some invalid generated YAML. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excessive chomping on Helm templates was causing the YAML divider `---` to end up appended to the end of the previous line.
AlexGodbehere
approved these changes
Jun 28, 2023
AlexGodbehere
pushed a commit
that referenced
this pull request
Mar 22, 2024
We were sometimes ending up with an `undefined` flux-system manifest, because cluster-manager had checked out the repo before git had had a chance to act on its auto-pull instructions. Rather than messing about just check out every time. Fix a small bug which occurred when checking out an empty repo, and make sure we refresh our cluster list every 10 minutes in case we miss a ConfigDB update. Fixes: #21 Fixes: #11
AlexGodbehere
added a commit
that referenced
this pull request
Mar 22, 2024
AlexGodbehere
added a commit
that referenced
this pull request
Mar 22, 2024
AlexGodbehere
pushed a commit
that referenced
this pull request
Mar 22, 2024
I'm not sure why I did this in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excessive chomping on Helm templates was causing the YAML divider
---to end up appended to the end of the previous line.