Improve package caching #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commented out unused `std::env` import in `vorpal.rs`. - Added validation for empty source hash, name, and signature in `run_prepare.rs`. - Refactored `run_prepare.rs` to remove redundant checks and improve readability. - Introduced `validate_hashes` and `send_source` functions in `package/mod.rs` for better separation of concerns. - Updated `prepare` function in `package/mod.rs` to use the new helper functions. - Changed file permissions for package tar files to `0o440` in `package/mod.rs`. - Renamed variables for clarity and consistency in `archives.rs`.
- Uncommented the `use std::env` statement. - Renamed the `request` variable to `coreutils` and added logic to process its stream. - Uncommented and updated the `example` package request logic. - Ensured both `coreutils` and `example` package requests are processed correctly.
…ndling - Removed redundant references to `workdir_path` and `name` in function calls. - Replaced string comparison with `is_empty()` for better readability and performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
proxyorbuildservice