Implement async compression #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated .gitignore to consolidate vorpal-related entries. - Added new dependencies to Cargo.lock and Cargo.toml, including `futures`, `process-stream`, and `tap`. - Modified example/rust/vorpal.rs to use `coreutils` instead of `busybox`. - Updated flake.nix with a new `cargoSha256` value. - Simplified justfile by removing redundant profiles and adding a `clean` task. - Fixed key directory path in src/service/build/mod.rs. - Replaced `tokio::process::Command` with `process_stream::Process` in src/service/build/run_build.rs for better process handling.
* feat: add tracing dependencies, update cargoSha256 - Add `tracing` and `tracing-subscriber` dependencies to `Cargo.toml` and `Cargo.lock` - Update `cargoSha256` in `flake.nix` to reflect new dependencies - Implement tracing level configuration in `src/command/mod.rs` * refactor: remove unused imports and replace println with logging - Remove `tracing_subscriber::layer::SubscriberExt` import as it's unused. - Replace `println!` with appropriate logging macros (`info`, `debug`, `error`) across various modules for better log management and consistency. - Adjust log messages to follow a consistent format, enhancing readability and maintainability of log output.
Co-authored-by: Erik Reinert <4638629+erikreinert@users.noreply.github.com>
- Removed unused import `PathBuf` from `src/service/proxy/package/mod.rs`. - Added `OsStr` and `info` imports in `src/store/mod.rs`. - Refactored `compress_tar_gz` function to use generic parameters for better flexibility and type safety. - Simplified the `append_path_with_name` and `append_dir_all` calls by removing unnecessary clones.
…tency Replaced println! statements with info! macro to ensure consistent logging practices across the codebase. This change affects the logging of prepared gzip and bzip2 sources in the prepare function.
The cargoSha256 hash for the buildRustPackage has been updated from "sha256-I9yYNZEGJml2MyLK6BshNro7wFpn8MdZpUeGyMJs2o0=" to "sha256-VrAN1joJAs7puM76oyHIByNxovhDrp6t2Xw2FiG5tT4=". This change ensures the integrity and correctness of the package dependencies.
- Refactored error handling in `run_prepare.rs` to use `if let` for better readability and maintainability. - Simplified the source kind preparation logic in `package/mod.rs` by replacing `match` with `if let` statements. - Improved code clarity and reduced nesting by handling specific MIME types directly in conditional blocks.
erikreinert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
async-compressiondependencies inCargo.tomlRemoved
tardependency inCargo.tomltempfiledependency inCargo.tomlChanged
flake.nixwith newcargoSha256justfilewith new build and start commandsvorpal.rsto use new dependenciesrun_build.rsto useprocess-streamfor streaming outputrun_prepare.rsto use async file operationsproxy/mod.rsto handle different compression formatsstore/mod.rsto use async-compression and tokio-tarFixed
mod.rsrun_build.rsandrun_prepare.rs