-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): mention only one user per block #2410
Merged
Merged
+117
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying akasha-core-framework with Cloudflare Pages
|
didd
force-pushed
the
mention-one-user-per-block
branch
from
September 19, 2024 13:13
d1e52ee
to
10c60d2
Compare
didd
force-pushed
the
mention-one-user-per-block
branch
from
September 19, 2024 13:15
10c60d2
to
9e53c27
Compare
quininez
previously approved these changes
Sep 19, 2024
quininez
approved these changes
Sep 20, 2024
SeverS
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces a change on beam editor that prevents users from mentioning more than one user per content block. If user attempts to do so a warning message will be displayed and will remain in view till the user removes the extra
@
. Since the message is a warning the publish button isn't affected by it.Issues that will be closed
Testing
Checklist