Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): mention only one user per block #2410

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Conversation

didd
Copy link
Member

@didd didd commented Sep 18, 2024

Description

The PR introduces a change on beam editor that prevents users from mentioning more than one user per content block. If user attempts to do so a warning message will be displayed and will remain in view till the user removes the extra @. Since the message is a warning the publish button isn't affected by it.

Issues that will be closed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

@didd didd self-assigned this Sep 18, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 18, 2024

Deploying akasha-core-framework with  Cloudflare Pages  Cloudflare Pages

Latest commit: f24ee70
Status: ✅  Deploy successful!
Preview URL: https://c313e8e2.akasha-world-framework.pages.dev
Branch Preview URL: https://mention-one-user-per-block.akasha-world-framework.pages.dev

View logs

@didd didd marked this pull request as ready for review September 19, 2024 08:11
@didd didd marked this pull request as draft September 19, 2024 13:06
@didd didd marked this pull request as ready for review September 19, 2024 13:39
quininez
quininez previously approved these changes Sep 19, 2024
@didd didd merged commit 48b6d27 into next Sep 20, 2024
7 checks passed
@didd didd deleted the mention-one-user-per-block branch September 20, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants