Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: UI fixes #2402

Open
wants to merge 13 commits into
base: next
Choose a base branch
from
Open

Chore: UI fixes #2402

wants to merge 13 commits into from

Conversation

josenriagu
Copy link
Member

@josenriagu josenriagu commented Sep 13, 2024

Description

  • update Tooltip component UI
  • increase spacing between blocks on beam card
  • update Auth screen UI
  • change icon size in profile settings

Issues that will be closed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

Signed-off-by: Josemaria Nriagu <josemaria.nriagu@akasha.world>
Signed-off-by: Josemaria Nriagu <josemaria.nriagu@akasha.world>
Signed-off-by: Josemaria Nriagu <josemaria.nriagu@akasha.world>
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2024

Deploying akasha-core-framework with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d9cbdd
Status: ✅  Deploy successful!
Preview URL: https://ea7cba35.akasha-world-framework.pages.dev
Branch Preview URL: https://chore-ui-fixes.akasha-world-framework.pages.dev

View logs

Signed-off-by: Josemaria Nriagu <josemaria.nriagu@akasha.world>
@josenriagu josenriagu marked this pull request as ready for review September 16, 2024 07:24
quininez
quininez previously approved these changes Sep 16, 2024
@didd
Copy link
Member

didd commented Sep 16, 2024

image
It seems the arrow's color on the tooltip is different from the content background.

Signed-off-by: Josemaria Nriagu <josemaria.nriagu@akasha.world>
didd
didd previously approved these changes Sep 17, 2024
@quininez
Copy link
Member

quininez commented Sep 19, 2024

in the design it looks like the shadow follows also the arrow of the tooltip on light theme, and on dark theme there is no shadow at all, which is different from the implementation. Right now in the implementation on dark theme the arrow looks weird and breaks the flow of the component.
https://www.figma.com/design/WbIHLctkDhGJjLKLhZcjCf/AKASHA-WORLD-DESIGN-SYSTEM?node-id=923-6497&node-type=canvas&t=zoCKN9ozKBtP4FUN-0

maybe @Basmatiii can take a look at this and clarify

Signed-off-by: Josemaria Nriagu <josemaria.nriagu@akasha.world>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants