Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extension creation form #2390

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Update extension creation form #2390

merged 5 commits into from
Sep 5, 2024

Conversation

quininez
Copy link
Member

@quininez quininez commented Sep 4, 2024 •
edited
Loading

Description

  • add post extension creation page to inform the user

Issues that will be closed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 4, 2024 •
edited
Loading

Deploying akasha-core-framework with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78947ec
Status: ✅  Deploy successful!
Preview URL: https://88c4f16c.akasha-world-framework.pages.dev
Branch Preview URL: https://update-extension-creation-fo.akasha-world-framework.pages.dev

View logs

@quininez quininez marked this pull request as ready for review September 5, 2024 08:02
@SeverS
Copy link
Member

SeverS commented Sep 5, 2024 •
edited
Loading

merging this after #2389 will be easier because of the routing plugin changes

getRoutingPlugin().navigateTo() will become getCorePlugins().routing.navigateTo()

otherwise this is good to be merged

SeverS
SeverS previously approved these changes Sep 5, 2024
View reviewed changes
josenriagu
josenriagu previously approved these changes Sep 5, 2024
View reviewed changes
@quininez quininez dismissed stale reviews from josenriagu and SeverS via 1a10399 September 5, 2024 09:35
@quininez quininez enabled auto-merge (squash) September 5, 2024 09:52
@quininez quininez merged commit ee9c4a0 into next Sep 5, 2024
7 checks passed
@quininez quininez deleted the update-extension-creation-form branch September 5, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverS SeverS SeverS approved these changes

@josenriagu josenriagu josenriagu approved these changes

@didd didd Awaiting requested review from didd didd is a code owner

Assignees
No one assigned
Labels
apps design-system extensions libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quininez @SeverS @josenriagu