Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(): bug fixes v2 #2386

Merged
merged 6 commits into from
Aug 30, 2024
Merged

chore(): bug fixes v2 #2386

merged 6 commits into from
Aug 30, 2024

Conversation

didd
Copy link
Member

@didd didd commented Aug 30, 2024

Description

  • offset calculation on virtual list component
  • apply line break on text editor when the text would overflow its content box
  • set maximum characters limit to profile name as 50
  • prevent pending reflection card from appearing when there is error during publishing
  • set maximum encoded length for reflect editor as 3000 rather than the default 6000

Issues that will be closed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

@didd didd self-assigned this Aug 30, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 30, 2024 •
edited
Loading

Deploying akasha-core-framework with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3f1dff
Status: ✅  Deploy successful!
Preview URL: https://052d7777.akasha-world-framework.pages.dev
Branch Preview URL: https://bug-fixes-v2.akasha-world-framework.pages.dev

View logs

@github-actions github-actions bot added the tests label Aug 30, 2024
@didd didd marked this pull request as ready for review August 30, 2024 12:39
@didd didd merged commit e6594fe into next Aug 30, 2024
7 checks passed
@didd didd deleted the bug-fixes-v2 branch August 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverS SeverS SeverS approved these changes

@josenriagu josenriagu josenriagu approved these changes

@quininez quininez Awaiting requested review from quininez quininez is a code owner

Assignees

@didd didd

Labels
apps design-system extensions fix libs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didd @SeverS @josenriagu