Improve thisdd4hep.sh setup scripts #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansenjo
changed the title
|
I'm checking why the CI checks are failing with this. The script works fine on my private machines. |
hansenjo
changed the title
|
This seems to be working now in the CI environment as well. The PR is ready to be reviewed. |
petricm
suggested changes
Nov 18, 2020
CMakeLists.txt
Outdated
| # ----for APPLE scripts have to set the DYLD_LIBRARY_PATH | ||
| if(APPLE) | ||
| set(USE_DYLD 1) | ||
| set(CMAKE_MACOSX_RPATH 1) |
There was a problem hiding this comment.
set(CMAKE_MACOSX_RPATH 1) is set in cmake/DD4hepBuild.cmake along with all the rpath treatment. And USE_DYLD could be drooped entirely in favor of using the variable APPLE
There was a problem hiding this comment.
Sure, that works. Requested changes made in commit d926c96
- Avoid duplicates in paths - Support whitespace in paths - Don't add system paths to library paths on macOS
hansenjo
force-pushed
the
joh-thisdd4hep
branch
from
1dafb56 to
d926c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES