Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements: Plugin service, dd4hep_add_dictionary #621

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Improvements: Plugin service, dd4hep_add_dictionary #621

merged 2 commits into from
Feb 17, 2020

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Feb 14, 2020 •
edited by petricm
Loading

BEGINRELEASENOTES

  • Cmake: dd4hep_add_dictionary: directly use command, no longer created bash script to be called. See details of call with make VERBOSE=1
  • PluginServiceV2: use boost::split instead of walking of char arrays, fix bug when two colons are in the environment variable. Fixes Conflicting thispackage.sh scripts for multiple packages #600
    ENDRELEASENOTES

@andresailer andresailer mentioned this pull request Feb 14, 2020
Closed
@andresailer
PluginServiceV2: boost components parser, incidentally fix bug preven…
02b0079 
…ting parsing env variables with repeating colons
@petricm petricm merged commit 84cf31e into AIDASoft:master Feb 17, 2020
@andresailer andresailer deleted the addDictImpr branch February 17, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petricm petricm petricm approved these changes

Assignees
No one assigned
Labels
bug fix cleanup enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting thispackage.sh scripts for multiple packages
2 participants
@andresailer @petricm