Fixed buggy geant4 vertex time from HepMC #1085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening the PR, this is much easier to browse than a patch file. |
andresailer
reviewed
Mar 30, 2023
| @@ -146,7 +147,7 @@ HEPMC3EventReader::readParticles(int event_number, Vertices& vertices, Particles | |||
| vtx->x = p->vex; | |||
| vtx->y = p->vey; | |||
| vtx->z = p->vez; | |||
| vtx->time = p->time; | |||
| vtx->time = p->vet; | |||
There was a problem hiding this comment.
Suggested change
| vtx->time = p->vet; | |
| vtx->time = vex.get_component(3) * len_unit / CLHEP::c_light; |
There was a problem hiding this comment.
Update the comment above to change vertex from three-vector to four-vector (0,0,0,0)
|
This breaks the "normal" root output: |
|
Oh, makes sense. Probably the extra serialized member. Yours looks like a good even more minimal version. |
|
Ok, I'll close this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1082
BEGINRELEASENOTES
ENDRELEASENOTES