-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParticleHandler: account for modified stepping actions, where tracking… #1046
Conversation
f8e088c
to
39fea41
Compare
@MarkusFrankATcernch Does this look sensible to you? |
If the tracking action is the first call to the particle handler after the restacking, this should be correct. Hence the question is: Whan does the restacking happen? before or after a couple of steps were already processed? |
if before the restacking the member
is called this approach should be correct. Be aware that this track may be in both collections:
in |
d8950e4
to
2fbf233
Compare
I implemented the treatment also for particles that might not be in the particleMap before they are suspended. It looks fine to me, but that code is never actually run so far. |
I am adding a test |
21ad59a
to
3e20bc1
Compare
Added a test that exercises the suspendedPM related code |
… of a particle could be paused and later restarted. Pick up the particle information that we have stored and go on from there
…re suspended This logic only incurs a runtime overhead of two if checks if no particles are ever suspended. Store non-primary particles that are suspended in a different map to pick their initial information up later again.
If we do not already store particles that become important'ish later we get a fatal error because the equilavent finding might not be able to find this particle
833a813
to
431faa2
Compare
… of a particle could be paused and later restarted.
Pick up the particle information that we have stored and go on from there
BEGINRELEASENOTES
ENDRELEASENOTES
For #1036 I get this for 2 events now
So the energy is the same as the initial one (10000) as opposed to some smaller number.