-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating utils from CAROT to CMonge #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why moving from utils
to analysis
, that's inducing an unnecessary breaking change.
If you have to move it, create a dummy import from the utils file to ensure backwards compatibility
Soo if I add the typing of ConditionDataModule and ConditionalMongeTrainer etc, there are circular imports. This only breaks a few notebooks (mostly in the CARs) which I have already changes. |
Alright but type hints are not enough of a reason to induce a breaking change in a pypi package. Let's use strings instead as recommended by PEP conventions https://peps.python.org/pep-0484/#forward-references |
So I tried this, if I don't import the modules, I still get |
Adding generic utils from CAROT to CMonge