Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version updates #126

Merged
merged 7 commits into from
Jan 4, 2025
Merged

Version updates #126

merged 7 commits into from
Jan 4, 2025

Conversation

haz
Copy link
Contributor

@haz haz commented Dec 29, 2024

Proposed changes

Fetching the latest from a pipenv lock run (which should clear out the vulnerability complaints from the dependabot). Other notable changes worth considering:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (8da9fec) to head (8348671).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          24       24           
  Lines        1752     1752           
  Branches      233      187   -46     
=======================================
  Hits         1544     1544           
  Misses        148      148           
  Partials       60       60           
Flag Coverage Δ
unittests 88.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pddl/__init__.py 100.00% <ø> (ø)
pddl/__main__.py 81.81% <ø> (ø)
pddl/__version__.py 100.00% <100.00%> (ø)
pddl/_validation.py 91.41% <ø> (ø)
pddl/action.py 92.85% <ø> (ø)
pddl/core.py 92.16% <ø> (ø)
pddl/custom_types.py 100.00% <ø> (ø)
pddl/exceptions.py 69.23% <ø> (ø)
pddl/formatter.py 96.92% <ø> (ø)
pddl/helpers/base.py 97.80% <ø> (ø)
... and 14 more

@haz
Copy link
Contributor Author

haz commented Dec 29, 2024

Just noticed that we don't even test on 3.12. Quick search shows where things pop up:

https://github.com/search?q=repo%3AAI-Planning%2Fpddl+3.11&type=code

@marcofavorito / @francescofuggitti : Should we shift what versions we cover? 3.10 - 3.12?

according to https://devguide.python.org/versions/, Python versions 3.7 and 3.8
are now at the end of life. This commit simply removes the references to such
Python versions across the whole codebase.
@marcofavorito
Copy link
Member

In e0e1107 I just removed all references to 3.7 and 3.8, since they are now at end-of-life.

In 0cd63e2 I added 3.11 and 3.12 in different places, like setuptools metadata and CI/testing configurations (tox.ini etc.).

Copy link
Member

@marcofavorito marcofavorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcofavorito
Copy link
Member

As a last change, I updated the year range in all occurrences of the copyright notice: 8348671.

@haz haz merged commit d0cc237 into main Jan 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants