-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version updates #126
Version updates #126
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 24 24
Lines 1752 1752
Branches 233 187 -46
=======================================
Hits 1544 1544
Misses 148 148
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Just noticed that we don't even test on 3.12. Quick search shows where things pop up: https://github.com/search?q=repo%3AAI-Planning%2Fpddl+3.11&type=code @marcofavorito / @francescofuggitti : Should we shift what versions we cover? 3.10 - 3.12? |
according to https://devguide.python.org/versions/, Python versions 3.7 and 3.8 are now at the end of life. This commit simply removes the references to such Python versions across the whole codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As a last change, I updated the year range in all occurrences of the copyright notice: 8348671. |
Proposed changes
Fetching the latest from a
pipenv lock
run (which should clear out the vulnerability complaints from the dependabot). Other notable changes worth considering:CHANGES.md
file, since it's grossly outdated and we get our changelog now from https://github.com/AI-Planning/pddl/releasesTypes of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.