Make prefilling return first token for loadgen integration #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @vipannalla |
vipannalla
reviewed
Jul 8, 2024
| @@ -278,7 +278,7 @@ def test_llama_e2e_two_addtional_tokens(self): | |||
| slot = 0 | |||
|
|
|||
| # pylint: disable-next=all | |||
| prefill_result = engine.prefill( | |||
| prefill_result, _ = engine.prefill( | |||
There was a problem hiding this comment.
Please add the first_token to the out_tokens array (Line 288), otherwise out_tokens will not equal expected_output_tokens. Same for all other calls..
jetstream_pt/engine.py
Outdated
Comment on lines
282
to
285
| tokens_idx = (0, 1), | ||
| valid_idx = (1, 2), | ||
| length_idx = (2, 3), | ||
| samples_per_slot = 1, |
There was a problem hiding this comment.
Suggestion: Instead of magic numbers, should use same logic as in generate so its clearer to reader:
length = token_out.shape[1]
result_tokens = engine_api.ResultTokens(
data=data,
tokens_idx=(0, length),
valid_idx=(length, 2 * length),
length_idx=(2 * length, 2 * length + 1),
samples_per_slot=1,
)
FanhaiLu1
reviewed
Jul 8, 2024
qihqi
approved these changes
Jul 10, 2024
wang2yn84
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Make prefilling return first token for loadgen integration * minor fix and lint * enable passing of max_decode_length as a flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.