Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to MHD BC functions for compatibility with new stores/packages #164

Merged
merged 1 commit into from
May 3, 2024

Conversation

joe-pitt
Copy link
Contributor

@joe-pitt joe-pitt commented May 1, 2024

Three changes (maybe should have separated these...):

  1. Add optional "fp_species" that allows the footprint species to be specified in you have short lifetime and/or co2 footprints in the same object store as the inert footprints. The wind direction should be the same in all fps, but we need to specify an fp species in this case.
  2. In the new object stores, wind_direction has become wind_from_direction
  3. In recent versions of xarray we need to use .compute() in conjunction with .where(). See discussion here: Indexing with a boolean dask array is not allowed... hainegroup/oceanspy#332

@brendan-m-murphy
Copy link
Contributor

This looks good, although it should be fixed on the OpenGHG side!

@joe-pitt joe-pitt merged commit 73b3ca2 into develop May 3, 2024
0 of 2 checks passed
@joe-pitt joe-pitt deleted the update_mhd_bc_script branch May 3, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants